[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_re
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report() |
Date: |
Fri, 18 Aug 2017 07:32:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 08/17/2017 02:55 PM, Alistair Francis wrote:
>>>> On 15/08/2017 09:30, Markus Armbruster wrote:
>>>>> The stupid fix is to repeat libraries until the link succeeds:
>>>>>
>>>>> test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a
>>>>>
> [...]
>>>>>
>>>>> Sticking '-Wp,-(' and '-Wp,-)' into the command line I get from make V=1
>>>>> doesn't work for me, though.
>>>>>
>>>>> The smart solution is not to have .a reference each other.
>>>>
>>>> Nah, I think we should teach those new kids on the block about -lX11
>>>> instead. :)
>>
>> This sounds scary...
>>
>>>>
>>>>> Paolo, what do you think?
>>>>
>>>> Another possibility is to just merge the two static libraries into one.
>>>
>>> Sounds good to me!
>>
>> I feel like I have opened a can of worms.
>
> you are good at it! IIRC it all started with a 1-line change in
> tcp_chr_wait_connected() more than 2 months ago :)
>
>>
>> I can try and combine libqemustub.a into libqemuutil.a is that the
>> solution? I just want to make sure before I start this.
>
> IMHO your series is OK like this, add a "TODO remove once
> libqemuutil.a circular dep is resolved" comment in the Makefile is
> enough, and let this issue for another time.
I disagree.
If merging the two .a is beyond your reach (I hope it isn't), then the
spot to mess up is this one:
# TODO bla bla explain bla
test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/03
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/14
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/14
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/15
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Paolo Bonzini, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(),
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/18
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/18
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/17