[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_re
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report() |
Date: |
Mon, 14 Aug 2017 15:34:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
PATCH 3/5 has the exact same subject. Why are the two separate?
Alistair Francis <address@hidden> writes:
> Convert any remaining uses of fprintf(stderr, "warning:"...
> to use warn_report() instead. This helps standardise on a single
> method of printing warnings to the user.
>
> All of the warnings were changed using this command:
> find ./* -type f -exec sed -i 's|fprintf(.*".*warning[,:]
> |warn_report("|Ig' {} +
>
> The #include lines and chagnes to the test Makefile were manually
changes
> updated to allow the code to compile.
>
> Signed-off-by: Alistair Francis <address@hidden>
> ---
>
> tests/Makefile.include | 4 ++--
> util/cutils.c | 3 ++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 7af278db55..4886caf565 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -560,8 +560,8 @@ tests/test-thread-pool$(EXESUF): tests/test-thread-pool.o
> $(test-block-obj-y)
> tests/test-iov$(EXESUF): tests/test-iov.o $(test-util-obj-y)
> tests/test-hbitmap$(EXESUF): tests/test-hbitmap.o $(test-util-obj-y)
> $(test-crypto-obj-y)
> tests/test-x86-cpuid$(EXESUF): tests/test-x86-cpuid.o
> -tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o
> migration/page_cache.o $(test-util-obj-y)
> -tests/test-cutils$(EXESUF): tests/test-cutils.o util/cutils.o
> +tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o
> migration/page_cache.o $(test-qom-obj-y)
> +tests/test-cutils$(EXESUF): tests/test-cutils.o util/cutils.o
> $(test-qom-obj-y)
No. What symbols exactly is the linker missing?
> tests/test-int128$(EXESUF): tests/test-int128.o
> tests/rcutorture$(EXESUF): tests/rcutorture.o $(test-util-obj-y)
> tests/test-rcu-list$(EXESUF): tests/test-rcu-list.o $(test-util-obj-y)
> diff --git a/util/cutils.c b/util/cutils.c
> index 1534682083..b33ede83d1 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -30,6 +30,7 @@
> #include "qemu/iov.h"
> #include "net/net.h"
> #include "qemu/cutils.h"
> +#include "qemu/error-report.h"
>
> void strpadcpy(char *buf, int buf_size, const char *str, char pad)
> {
> @@ -601,7 +602,7 @@ int parse_debug_env(const char *name, int max, int
> initial)
> return initial;
> }
> if (debug < 0 || debug > max || errno != 0) {
> - fprintf(stderr, "warning: %s not in [0, %d]", name, max);
> + warn_report("%s not in [0, %d]", name, max);
> return initial;
> }
> return debug;
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/03
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(),
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/14
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/15
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Paolo Bonzini, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/17
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Markus Armbruster, 2017/08/18
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Alistair Francis, 2017/08/18
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/18
- Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report(), Philippe Mathieu-Daudé, 2017/08/17