[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyE
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent |
Date: |
Fri, 11 Aug 2017 10:13:42 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, Aug 10, 2017 at 02:02:32PM -0500, Eric Blake wrote:
> On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> > Now that keycode numbers are converted to QKeyCodes immediately
> > when creating input events, the InputKeyEvent struct can be
> > changed to only accept a QKeyCode, instead of a KeyValue.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
>
> > +++ b/qapi-schema.json
> > @@ -5747,7 +5747,7 @@
> > # Since: 2.0
> > ##
> > { 'struct' : 'InputKeyEvent',
> > - 'data' : { 'key' : 'KeyValue',
> > + 'data' : { 'key' : 'QKeyCode',
> > 'down' : 'bool' } }
>
> Isn't this going to break backwards-compatibility of 'input-send-event'?
>
> I think you have to keep the public API the same, even if you make the
> conversion as early as possible to the preferred mapping form internally.
Oh urgh, I never noticed there even was an "input-send-event" command,
only "send-key".
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 01/15] ui: add keycodemapdb repository as a GIT submodule, (continued)
- [Qemu-devel] [PATCH 02/15] ui: convert common input code to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 03/15] ui: convert key events to QKeyCodes immediately, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 04/15] ui: don't export qemu_input_event_new_key, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 09/15] char: convert the escc device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 07/15] input: convert ps2 device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 08/15] input: convert the adb device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 10/15] ui: convert cocoa frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 11/15] ui: convert the SDL2 frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 12/15] ui: convert GTK and SDL1 frontends to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 14/15] ui: remove qemu_input_linux_to_qcode method, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 15/15] display: convert XenInput keyboard to keycodemapdb, Daniel P. Berrange, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, no-reply, 2017/08/10