[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method |
Date: |
Thu, 10 Aug 2017 16:55:20 +0100 |
The qemu_input_qcode_to_number method is only used in one place and
no new code should require it, so inline it at the only caller.
Signed-off-by: Daniel P. Berrange <address@hidden>
---
include/ui/input.h | 1 -
ui/input-keymap.c | 16 +++++++---------
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/include/ui/input.h b/include/ui/input.h
index 7ac1d62747..b3827b6082 100644
--- a/include/ui/input.h
+++ b/include/ui/input.h
@@ -42,7 +42,6 @@ void qemu_input_event_send_key_number(QemuConsole *src, int
num, bool down);
void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down);
void qemu_input_event_send_key_delay(uint32_t delay_ms);
int qemu_input_key_number_to_qcode(unsigned int nr);
-int qemu_input_qcode_to_number(QKeyCode qcode);
int qemu_input_qcode_to_scancode(QKeyCode qcode, bool down, int *codes);
int qemu_input_linux_to_qcode(unsigned int lnx);
diff --git a/ui/input-keymap.c b/ui/input-keymap.c
index 566b8f2000..71c6a79e66 100644
--- a/ui/input-keymap.c
+++ b/ui/input-keymap.c
@@ -32,14 +32,6 @@ int qemu_input_linux_to_qcode(unsigned int lnx)
return qemu_input_map_linux2qcode[lnx];
}
-int qemu_input_qcode_to_number(QKeyCode qcode)
-{
- if (qcode >= qemu_input_map_qcode2qnum_len) {
- return 0;
- }
- return qemu_input_map_qcode2qnum[qcode];
-}
-
int qemu_input_key_number_to_qcode(unsigned int nr)
{
if (nr >= qemu_input_map_qnum2qcode_len) {
@@ -51,9 +43,15 @@ int qemu_input_key_number_to_qcode(unsigned int nr)
int qemu_input_qcode_to_scancode(QKeyCode qcode, bool down,
int *codes)
{
- int keycode = qemu_input_qcode_to_number(qcode);
+ int keycode;
int count = 0;
+ if (qcode >= qemu_input_map_qcode2qnum_len) {
+ keycode = 0;
+ } else {
+ keycode = qemu_input_map_qcode2qnum[qcode];
+ }
+
if (qcode == Q_KEY_CODE_PAUSE) {
/* specific case */
int v = down ? 0 : 0x80;
--
2.13.3
- Re: [Qemu-devel] [PATCH 06/15] input: convert virtio-input-hid device to keycodemapdb, (continued)
- [Qemu-devel] [PATCH 05/15] ui: use QKeyCode exclusively in InputKeyEvent, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 09/15] char: convert the escc device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 07/15] input: convert ps2 device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 08/15] input: convert the adb device to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 10/15] ui: convert cocoa frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 11/15] ui: convert the SDL2 frontend to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 12/15] ui: convert GTK and SDL1 frontends to keycodemapdb, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 13/15] ui: remove qemu_input_qcode_to_number method,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 14/15] ui: remove qemu_input_linux_to_qcode method, Daniel P. Berrange, 2017/08/10
- [Qemu-devel] [PATCH 15/15] display: convert XenInput keyboard to keycodemapdb, Daniel P. Berrange, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, no-reply, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, no-reply, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, no-reply, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, no-reply, 2017/08/10
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, Gerd Hoffmann, 2017/08/21
- Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb, Programmingkid, 2017/08/12