[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functi
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header |
Date: |
Tue, 11 Jul 2017 11:05:07 +0200 |
On Tue, 11 Jul 2017 10:52:24 +0200
Thomas Huth <address@hidden> wrote:
> On 11.07.2017 09:59, Cornelia Huck wrote:
> > On Mon, 10 Jul 2017 17:32:35 +0200
> > Thomas Huth <address@hidden> wrote:
> >
> >> We'll need them in code that is not related to bootmap.h, so
> >> they should reside in an independent header.
> >>
> >> Signed-off-by: Thomas Huth <address@hidden>
> >> ---
> >> pc-bios/s390-ccw/bootmap.c | 1 +
> >> pc-bios/s390-ccw/bootmap.h | 26 --------------------------
> >> pc-bios/s390-ccw/bswap.h | 25 +++++++++++++++++++++++++
> >> 3 files changed, 26 insertions(+), 26 deletions(-)
> >> create mode 100644 pc-bios/s390-ccw/bswap.h
> >
> >> diff --git a/pc-bios/s390-ccw/bswap.h b/pc-bios/s390-ccw/bswap.h
> >> new file mode 100644
> >> index 0000000..45b5ef4
> >> --- /dev/null
> >> +++ b/pc-bios/s390-ccw/bswap.h
> >
> > Add a copyright/licence text?
>
> The original file include/qemu/bswap.h (where this code comes from) also
> does not have a copyright statement, so I was not sure which one to add
> here. I think that simply means that the default applies here...
> But I can certainly also add the default GPLv2+ statement if you think
> that we need it here...
No, that's fine; it's just the only file in this subdirectory without
an explicit header...
Acked-by: Cornelia Huck <address@hidden>
- Re: [Qemu-devel] [PATCH v3 02/10] pc-bios/s390-ccw: Move ebc2asc to sclp.c, (continued)
- [Qemu-devel] [PATCH v3 07/10] roms/SLOF: Update submodule to latest status, Thomas Huth, 2017/07/10
- [Qemu-devel] [PATCH v3 06/10] pc-bios/s390-ccw: Add code for virtio feature negotiation, Thomas Huth, 2017/07/10
- [Qemu-devel] [PATCH v3 08/10] pc-bios/s390-ccw: Add core files for the network bootloading program, Thomas Huth, 2017/07/10
- [Qemu-devel] [PATCH v3 09/10] pc-bios/s390-ccw: Add virtio-net driver code, Thomas Huth, 2017/07/10
- [Qemu-devel] [PATCH v3 10/10] pc-bios/s390-ccw: Link libnet into the netboot image and do the TFTP load, Thomas Huth, 2017/07/10