[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callba
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn |
|
Date: |
Tue, 11 Jul 2017 11:03:29 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 11.07.2017 um 10:41 hat Paolo Bonzini geschrieben:
> On 11/07/2017 10:39, Kevin Wolf wrote:
> > Can you just add a comment to this effect to qcow2/qed_do_open() then?
>
> Good point.
>
> >>> Or maybe the cleaner way would be bdrv_drained_begin/end() around
> >>> everything directly in bdrv_co_invalidate_cache().
> >
> > Should we do this anyway? Or assert that no requests are in flight?
>
> I can certainly add assertions for clarity, but wouldn't requests have
> failed the permission checks and caused assertion failures already?
I'm pretty sure that read requests are allowed on inactive images.
Kevin
- [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn, (continued)
[Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2017/07/10
[Qemu-devel] [PATCH 4/5] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2017/07/10
[Qemu-devel] [PATCH 2/5] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2017/07/10
[Qemu-devel] [PATCH 5/5] block: convert bdrv_check callback to coroutine_fn, Paolo Bonzini, 2017/07/10