[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error |
Date: |
Thu, 04 May 2017 16:44:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
I'd like to rephrase "ignore query-commands error" to "Cope with
query-commands error" on commit, if you don't mind.
Marc-André Lureau <address@hidden> writes:
> qemu-ga doesn't implement it.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qmp/qmp-shell | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index f80d02312a..04b8fa3eae 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -126,7 +126,10 @@ class QMPShell(qmp.QEMUMonitorProtocol):
> return arg
>
> def _fill_completion(self):
> - for cmd in self.cmd('query-commands')['return']:
> + cmds = self.cmd('query-commands')
> + if cmds.has_key('error'):
> + return
> + for cmd in cmds['return']:
> self._completer.append(cmd['name'])
>
> def __completer_setup(self):
- [Qemu-devel] [PATCH 0/4] qmp-shell: learn to connect to qemu-ga, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 1/4] qmp-shell: add -N option to skip negotiate, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if unavailable, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 4/4] qmp-shell: improve help, Marc-André Lureau, 2017/05/04
- Re: [Qemu-devel] [PATCH 0/4] qmp-shell: learn to connect to qemu-ga, Markus Armbruster, 2017/05/04