[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error |
Date: |
Thu, 4 May 2017 08:50:13 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/04/2017 07:54 AM, Marc-André Lureau wrote:
> qemu-ga doesn't implement it.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qmp/qmp-shell | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index f80d02312a..04b8fa3eae 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -126,7 +126,10 @@ class QMPShell(qmp.QEMUMonitorProtocol):
> return arg
>
> def _fill_completion(self):
> - for cmd in self.cmd('query-commands')['return']:
> + cmds = self.cmd('query-commands')
> + if cmds.has_key('error'):
> + return
> + for cmd in cmds['return']:
> self._completer.append(cmd['name'])
>
> def __completer_setup(self):
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/4] qmp-shell: learn to connect to qemu-ga, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 1/4] qmp-shell: add -N option to skip negotiate, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if unavailable, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 4/4] qmp-shell: improve help, Marc-André Lureau, 2017/05/04
- Re: [Qemu-devel] [PATCH 0/4] qmp-shell: learn to connect to qemu-ga, Markus Armbruster, 2017/05/04