Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

[Eric Blake]

On 05/04/2017 02:23 AM, Markus Armbruster wrote:

>>> Feel free to suggest something for me to add to the commit message.
>>
>> Maybe change:
>>
>>   "which matches the documented actions that a real QGA client
>>    is supposed to do."
>>
>> to
>>
>>   "which is compatible with the documented actions that a real
>>    QGA client is supposed to do."
>>
>> and add the following comment to test_qga_sync_delimited
>>
>>   /* 
>>    * Note that the full reset sequence would involve checking the
>>    * response of guest-sync-delimited and repeating the loop if
>>    * 'id' field of the response does not match the 'id' field of 
>>    * the request. Testing this fully would require inserting
>>    * garbage in the response stream and is left as a future test
>>    * to implement.
>>    */
> 
> Eric, want me to squash that in?

Yes, those changes are reasonable.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature