Re: [Qemu-devel] [PATCH v9 00/10] replay additions

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v9 00/10] replay additions
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
bf3cfc0 icount: fixed saving/restoring of icount warp timers
37b3637 replay: save prior value of the host clock
0a8766b replay: make safe vmstop at record/replay
3aecd8c replay: added replay log format description
0d8963d replay: fix save/load vm for non-empty queue
9c14e13 replay: fixed replay_enable_events
70c9cd1 replay: fix processing async events
37292c3 replay: disable default snapshot for record/replay
5973813 blkreplay: create temporary overlay for underlaying devices
f34a13b block: implement bdrv_snapshot_goto for blkreplay

=== OUTPUT BEGIN ===
Checking PATCH 1/10: block: implement bdrv_snapshot_goto for blkreplay...
Checking PATCH 2/10: blkreplay: create temporary overlay for underlaying 
devices...
Checking PATCH 3/10: replay: disable default snapshot for record/replay...
Checking PATCH 4/10: replay: fix processing async events...
Checking PATCH 5/10: replay: fixed replay_enable_events...
Checking PATCH 6/10: replay: fix save/load vm for non-empty queue...
WARNING: line over 80 characters
#45: FILE: migration/savevm.c:2088:
+        monitor_printf(mon, "Record/replay does not allow making snapshot 
right now. "

ERROR: Error messages should not contain newlines
#59: FILE: migration/savevm.c:2256:
+                     "Try stopping at another step.\n");

total: 1 errors, 1 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/10: replay: added replay log format description...
Checking PATCH 8/10: replay: make safe vmstop at record/replay...
Checking PATCH 9/10: replay: save prior value of the host clock...
Checking PATCH 10/10: icount: fixed saving/restoring of icount warp timers...
ERROR: line over 90 characters
#98: FILE: cpus.c:595:
+            if (timers_state.vm_clock_warp_start == -1 || 
timers_state.vm_clock_warp_start > clock) {

WARNING: line over 80 characters
#103: FILE: cpus.c:599:
+            timer_mod_anticipate(timers_state.icount_warp_timer, clock + 
deadline);

ERROR: spaces required around that '*' (ctx:VxV)
#168: FILE: cpus.c:685:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 2 errors, 1 warnings, 172 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden