[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParam
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams |
Date: |
Thu, 04 May 2017 10:51:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> We have change in the previous patch to use migration capabilities for
>> it. Notice that we continue using the old command line flags from
>> migrate command from the time being. Remove the set_params method as
>> now it is empty.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/migration/migration.h | 3 +--
>> migration/block.c | 17 ++---------------
>> migration/colo.c | 3 ---
>> migration/migration.c | 8 +++++---
>> migration/savevm.c | 2 --
>> 5 files changed, 8 insertions(+), 25 deletions(-)
>>
>> diff --git a/migration/colo.c b/migration/colo.c
>> index c19eb3f..5c6c2f0 100644
>> --- a/migration/colo.c
>> +++ b/migration/colo.c
>> @@ -332,9 +332,6 @@ static int colo_do_checkpoint_transaction(MigrationState
>> *s,
>> goto out;
>> }
>>
>> - /* Disable block migration */
>> - s->params.blk = 0;
>> - s->params.shared = 0;
>
> Hmm you don't seem to have replaced this with anything.
> I think that's a behavioural change; the trick COLO did (I'm not sure if this
> is still the way it works) is that they initiate the first migration
> with block migration enabled so that the two hosts (with non-shared storage)
> get sync'd storage, and then at the completion of that first migration
> they then switch into the checkpointing mode where they're only
> doing updates - that's why it gets switched off at this point
> prior to the 1st checkpoint.
Weird, really.
I did't catch that.
Will investigate.
Thanks.
- Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams,
Juan Quintela <=