[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag |
Date: |
Thu, 6 Apr 2017 11:42:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04.04.2017 22:24, Eduardo Habkost wrote:
> kvmclock should be used by guests only when the appropriate CPUID
> feature flags are set on the VCPU, and it is automatically
> created by kvmclock_create() when those feature flags are set.
> This means creating a kvmclock device using -device is useless.
> Remove user_creatable from its device class.
Actually, I think this device should not be a sysbus device at all,
should it? It does not have any IO, GPIO or IRQ lines, so sysbus does
not make sense here, it should be of type TYPE_DEVICE instead.
Anyway, that's another topic. For your patch:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, (continued)
- [Qemu-devel] [PATCH v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 04/21] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- Re: [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag,
Thomas Huth <=
- [Qemu-devel] [PATCH v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 11/21] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 10/21] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 15/21] esp: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 16/21] generic-sdhci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 17/21] hpet: Remove user_creatable flag, Eduardo Habkost, 2017/04/04