[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag |
Date: |
Tue, 4 Apr 2017 17:24:14 -0300 |
TYPE_CFI_PFLASH01 devices need to be mapped by
pflash_cfi01_register() (or equivalent) and can't be used with
-device. Remove user_creatable from the device class.
Cc: Kevin Wolf <address@hidden>
Cc: Max Reitz <address@hidden>
Cc: address@hidden
Cc: Laszlo Ersek <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
Changes v1 -> v2:
* Commit message rewrite only
---
hw/block/pflash_cfi01.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index ef71956433..594d4cf6fe 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/block/pflash_cfi01.c
@@ -927,11 +927,6 @@ static void pflash_cfi01_class_init(ObjectClass *klass,
void *data)
dc->props = pflash_cfi01_properties;
dc->vmsd = &vmstate_pflash;
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
- dc->user_creatable = true;
}
--
2.11.0.259.g40922b1
- Re: [Qemu-devel] [PATCH v2 01/21] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, (continued)
- [Qemu-devel] [PATCH v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 04/21] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 06/21] pflash_cfi01: Remove user_creatable flag,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v2 07/21] kvmclock: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 08/21] ioapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 09/21] kvmvapic: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 12/21] isabus-bridge: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 11/21] allwinner-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 10/21] sysbus-ahci: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 13/21] unimplemented-device: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 14/21] fw_cfg: Remove user_creatable flag, Eduardo Habkost, 2017/04/04
- [Qemu-devel] [PATCH v2 15/21] esp: Remove user_creatable flag, Eduardo Habkost, 2017/04/04