|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 10/18] tcg/i386: add support for vector opcodes |
Date: | Wed, 18 Jan 2017 10:22:00 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 01/18/2017 05:05 AM, Kirill Batuzov wrote:
Why are you not defining xmm8-15?At first I thought about supporting both x86_64 and i386 targets, but put this idea away (at least for the time being). Since defining xmm8-15 does not contradict anything (as I see it now) I'll add them too.
Thanks. Although (potentialy) all you need to do to support i386 is to make sure that TCG_TARGET_HAS_add_* are properly conditionalized on a runtime have_sse2 check. There are other examples of how such runtime checks should be done.
(That said, I can imagine there might be other issues with respect to i64 vs v64 that might turn out to be complicated. It wouldn't bother me if we restricted vector support to 64-bit hosts.)
r~
[Prev in Thread] | Current Thread | [Next in Thread] |