[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault |
Date: |
Thu, 15 Dec 2016 09:47:38 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.12.2016 um 23:49 hat Michael S. Tsirkin geschrieben:
> On Wed, Dec 14, 2016 at 02:25:18PM +0000, Stefan Hajnoczi wrote:
> > The "Copy" menu item copies VTE terminal text to the clipboard. This
> > only works with VTE terminals, not with graphics consoles.
> >
> > Disable the menu item when the current notebook page isn't a VTE
> > terminal.
> >
> > This patch fixes a segfault. Reproducer: Start QEMU and click the Copy
> > menu item when the guest display is visible.
> >
> > Reported-by: Kevin Wolf <address@hidden>
> > Cc: Michael S. Tsirkin <address@hidden>
> > Cc: Gerd Hoffmann <address@hidden>
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
>
> I don't think it's 2.8 personally, patch just disables an
> illegal action. Similar to the hotplug crash fix I
> have queued. Just document this as a known issue.
This is an immediate crash for selecting a menu entry in the default
view (which means killing a VM accidentally), we know the patch to fix
it, and it is really small. Why would we not merge something like this?
Are we making intentionally shitty releases these days?
I don't know your hotplug problem, but if it's a crash that isn't a
real corner case, that suggests that it should have been fixed. I mean,
fixing bugs is exactly what the freeze is for.
Kevin
- [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault, Stefan Hajnoczi, 2016/12/14
- Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault, Stefan Weil, 2016/12/14
- Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault, Gerd Hoffmann, 2016/12/14
- Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault, Michael S. Tsirkin, 2016/12/14
- [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Michael S. Tsirkin, 2016/12/14
- Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Stefan Hajnoczi, 2016/12/15
- Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Michael S. Tsirkin, 2016/12/15
- Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Gerd Hoffmann, 2016/12/15
- Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Michael S. Tsirkin, 2016/12/15
- Re: [Qemu-devel] regression in 2.8: unable to exit screen grab in SDL mode, Michael S. Tsirkin, 2016/12/15