[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault |
Date: |
Thu, 15 Dec 2016 07:48:16 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Dec 15, 2016 at 12:49:06AM +0200, Michael S. Tsirkin wrote:
> On Wed, Dec 14, 2016 at 02:25:18PM +0000, Stefan Hajnoczi wrote:
> > The "Copy" menu item copies VTE terminal text to the clipboard. This
> > only works with VTE terminals, not with graphics consoles.
> >
> > Disable the menu item when the current notebook page isn't a VTE
> > terminal.
> >
> > This patch fixes a segfault. Reproducer: Start QEMU and click the Copy
> > menu item when the guest display is visible.
> >
> > Reported-by: Kevin Wolf <address@hidden>
> > Cc: Michael S. Tsirkin <address@hidden>
> > Cc: Gerd Hoffmann <address@hidden>
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
>
> I don't think it's 2.8 personally, patch just disables an
> illegal action. Similar to the hotplug crash fix I
> have queued. Just document this as a known issue.
I mistakenly thought this bug was introduced in QEMU 2.8, but now that I
look back at git log I realize it already existed.
Stefan
signature.asc
Description: PGP signature