qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system mode.


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system mode.
Date: Fri, 4 Nov 2016 10:00:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0


On 03/11/2016 18:30, Julian Brown wrote:
> +#ifdef CONFIG_USER_ONLY
>      size = be32_to_cpu(size);
> +#else
> +    /* If we're running in BE32 system mode, we don't need to do an explicit
> +     * byte swap, because (I think) target memory is already stored in
> +     * byte-swapped format.

Isn't this true also of user-mode (both BE8 and BE32)?

Paolo

> +     */
> +    if (!arm_sctlr_b(env)) {
> +        size = be32_to_cpu(size);
> +    }
> +#endif



reply via email to

[Prev in Thread] Current Thread [Next in Thread]