[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a n
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO |
Date: |
Thu, 27 Oct 2016 09:27:00 +0530 |
On (Wed) 26 Oct 2016 [22:05:22], Hailiang Zhang wrote:
> On 2016/10/26 13:06, Amit Shah wrote:
> >On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote:
> >>This new communication path will be used for returning messages
> >>from Secondary side to Primary side.
> >>
> >>Signed-off-by: zhanghailiang <address@hidden>
> >>Signed-off-by: Li Zhijian <address@hidden>
> >>Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> >
> >Reviewed-by: Amit Shah <address@hidden>
> >
> >>@@ -63,8 +75,24 @@ void *colo_process_incoming_thread(void *opaque)
> >> migrate_set_state(&mis->state, MIGRATION_STATUS_ACTIVE,
> >> MIGRATION_STATUS_COLO);
> >>
> >>+ mis->to_src_file = qemu_file_get_return_path(mis->from_src_file);
> >>+ if (!mis->to_src_file) {
> >>+ error_report("COLO incoming thread: Open QEMUFile to_src_file
> >>failed");
> >>+ goto out;
> >>+ }
> >>+ /*
> >>+ * Note: We set the fd to unblocked in migration incoming coroutine,
> >>+ * But here we are in the COLO incoming thread, so it is ok to set the
> >>+ * fd back to blocked.
> >>+ */
> >>+ qemu_file_set_blocking(mis->from_src_file, true);
> >
> >Why does it need to be blocking?
> >
>
> Because, the communication/action between Primary side and Secondary side
> should be
> sequential. Just as postcopy does. :)
Yea - I mean please include that in the comment too so it's obvious
why it's done.
Amit
- Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover, (continued)
[Qemu-devel] [PATCH COLO-Frame (Base) v21 06/17] COLO: Introduce checkpointing protocol, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 01/17] migration: Introduce capability 'x-colo' to migration, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 09/17] COLO: Load VMState into QIOChannelBuffer before restore it, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint, zhanghailiang, 2016/10/18
[Qemu-devel] [PATCH COLO-Frame (Base) v21 07/17] COLO: Add a new RunState RUN_STATE_COLO, zhanghailiang, 2016/10/18