Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover

[Hailiang Zhang]

On 2016/10/26 21:59, Dr. David Alan Gilbert wrote:
> * Amit Shah (address@hidden) wrote:
> > On (Tue) 18 Oct 2016 [20:10:08], zhanghailiang wrote:
> > > We leave users to choose whatever heartbeat solution they want,
> > > if the heartbeat is lost, or other errors they detect, they can use
> > > experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover,
> > > COLO will do operations accordingly.
> > >
> > > For example, if the command is sent to the PVM, the Primary side will
> > > exit COLO mode and take over operation.
> >
> > Primary should already be in control, so there's nothing special
> > needed to 'take over operation'?  At max, it should not do periodic
> > syncs anymore till it hears from a (new) secondary.
>
> But it has to stop waiting for an ack from the secondary, and stop sending
> copies of block data to it etc.

Yes, you are right, we still need to do this cleanup work :)

Thanks,
hailiang

> Dave
>
> > > If sent to the Secondary, the
> > > secondary will run failover work, then take over server operation to
> > > become the new Primary.
> > >
> > > Cc: Luiz Capitulino <address@hidden>
> > > Cc: Eric Blake <address@hidden>
> > > Cc: Markus Armbruster <address@hidden>
> > > Signed-off-by: zhanghailiang <address@hidden>
> > > Signed-off-by: Li Zhijian <address@hidden>
> > > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> >
> > Reviewed-by: Amit Shah <address@hidden>
> >
> >
> >                 Amit
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
> .