[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/15] Migration
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/15] Migration |
Date: |
Thu, 6 Oct 2016 11:59:09 +0100 |
On 5 October 2016 at 14:44, Juan Quintela <address@hidden> wrote:
> From: Juan Quintela <address@hidden>
>
> The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2016-10-04 14:25:08 +0100)
>
> are available in the git repository at:
>
> git://github.com/juanquintela/qemu.git tags/migration/20161005-1
>
> for you to fetch changes up to c62da143b6792cc32dbd5db15b936d7f58cc36ee:
>
> docs/xbzrle: correction (2016-10-05 14:28:41 +0200)
>
> ----------------------------------------------------------------
> migration/next for 20161005
>
> Hi
>
> This get:
> - documentation fix: Cao
> - improve max-bandwidth and downtime-limit (Ashijeet)
> - move migration commands to "boxed" (Eric)
> - rdma fixes (David)
> - postcopy fixes (David)
> - better errors (David)
>
> Please apply
This runs into the "OSX %zu vs SIZE_MAX" issue again:
/Users/pm215/src/qemu-for-merges/migration/migration.c:810:61:
warning: format specifies type 'size_t' (aka 'unsigned long') but the
argument has type 'unsigned long long' [-Wformat]
" range of 0 to %zu bytes/second", SIZE_MAX);
~~~ ^~~~~~~~
%llu
/Users/pm215/src/qemu-for-merges/include/qapi/error.h:163:35: note:
expanded from macro 'error_setg'
(fmt), ## __VA_ARGS__)
^
/usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
#define SIZE_MAX UINT64_MAX
^~~~~~~~~~
/usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
#define UINT64_MAX 18446744073709551615ULL
^~~~~~~~~~~~~~~~~~~~~~~
In the absence of a suitable configure test and override of SIZE_MAX,
we've been adding explicit (uint64_t) casts in the printf as the
simplest workaround.
thanks
-- PMM
- [Qemu-devel] [PULL 05/15] migration/rdma: Don't flag an error when we've been told about one, (continued)
- [Qemu-devel] [PULL 05/15] migration/rdma: Don't flag an error when we've been told about one, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 07/15] migrate: Share common MigrationParameters struct, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 08/15] migrate: Use boxed qapi for migrate-set-parameters, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 09/15] migrate: Fix bounds check for migration parameters in migration.c, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 10/15] Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8], Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 12/15] migration/postcopy: Explicitly disallow huge pages, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 13/15] migration: Fix seg with missing port, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 14/15] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 11/15] RAMBlocks: Store page size, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 15/15] docs/xbzrle: correction, Juan Quintela, 2016/10/05
- Re: [Qemu-devel] [PULL 00/15] Migration,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 00/15] Migration, Peter Maydell, 2016/10/12