[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/15] migrate: Fix bounds check for migration parame
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 09/15] migrate: Fix bounds check for migration parameters in migration.c |
Date: |
Wed, 5 Oct 2016 15:45:03 +0200 |
From: Ashijeet Acharya <address@hidden>
This patch fixes the out-of-bounds check of migration parameters in
qmp_migrate_set_parameters() for cpu-throttle-initial and
cpu-throttle-increment by adding a return statement for both as they
were broken since their introduction in 2.5 via commit 1626fee.
Due to the missing return statements, parameters were getting set to
out-of-bounds values despite the error.
Signed-off-by: Ashijeet Acharya <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 42336e3..04b706f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -796,6 +796,7 @@ void qmp_migrate_set_parameters(MigrationParameters
*params, Error **errp)
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"cpu_throttle_initial",
"an integer in the range of 1 to 99");
+ return;
}
if (params->has_cpu_throttle_increment &&
(params->cpu_throttle_increment < 1 ||
@@ -803,6 +804,7 @@ void qmp_migrate_set_parameters(MigrationParameters
*params, Error **errp)
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"cpu_throttle_increment",
"an integer in the range of 1 to 99");
+ return;
}
if (params->has_compress_level) {
--
2.7.4
- [Qemu-devel] [PULL 00/15] Migration, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 01/15] migration: report an error giving the failed field, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 04/15] migration: Make failed migration load set file error, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 03/15] migration/rdma: Pass qemu_file errors across link, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 02/15] migration: Report values for comparisons, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 06/15] migrate: Fix cpu-throttle-increment regression in HMP, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 05/15] migration/rdma: Don't flag an error when we've been told about one, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 07/15] migrate: Share common MigrationParameters struct, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 08/15] migrate: Use boxed qapi for migrate-set-parameters, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 09/15] migrate: Fix bounds check for migration parameters in migration.c,
Juan Quintela <=
- [Qemu-devel] [PULL 10/15] Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8], Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 12/15] migration/postcopy: Explicitly disallow huge pages, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 13/15] migration: Fix seg with missing port, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 14/15] migrate: move max-bandwidth and downtime-limit to migrate_set_parameter, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 11/15] RAMBlocks: Store page size, Juan Quintela, 2016/10/05
- [Qemu-devel] [PULL 15/15] docs/xbzrle: correction, Juan Quintela, 2016/10/05
- Re: [Qemu-devel] [PULL 00/15] Migration, Peter Maydell, 2016/10/06