[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 12/17] vfio/platform: fix a wrong returned value
From: |
Eric Auger |
Subject: |
[Qemu-devel] [PATCH v4 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device |
Date: |
Mon, 3 Oct 2016 12:41:12 +0000 |
In case the vfio_init_intp fails we currently do not return an
error value. This patch fixes the bug. The returned value is not
explicit but in practice the error object is the one used to
report the error to the end-user and the actual returned error
value is not used.
Signed-off-by: Eric Auger <address@hidden>
---
hw/vfio/platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
index 1a35da0..484e31f 100644
--- a/hw/vfio/platform.c
+++ b/hw/vfio/platform.c
@@ -508,6 +508,7 @@ static int vfio_populate_device(VFIODevice *vbasedev, Error
**errp)
irq.flags);
intp = vfio_init_intp(vbasedev, irq, errp);
if (!intp) {
+ ret = -1;
goto irq_err;
}
}
--
1.9.1
- [Qemu-devel] [PATCH v4 05/17] vfio/pci: Pass an error object to vfio_intx_enable, (continued)
- [Qemu-devel] [PATCH v4 05/17] vfio/pci: Pass an error object to vfio_intx_enable, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 07/17] vfio/pci: Pass an error object to vfio_pci_igd_opregion_init, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 08/17] vfio: Pass an Error object to vfio_connect_container, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 06/17] vfio/pci: Pass an error object to vfio_add_capabilities, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 09/17] vfio: Pass an error object to vfio_get_group, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 10/17] vfio: Pass an error object to vfio_get_device, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 11/17] vfio/platform: Pass an error object to vfio_populate_device, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 12/17] vfio/platform: fix a wrong returned value in vfio_populate_device,
Eric Auger <=
- [Qemu-devel] [PATCH v4 15/17] vfio/pci: Remove vfio_msix_early_setup returned value, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 14/17] vfio/pci: Conversion to realize, Eric Auger, 2016/10/03
- [Qemu-devel] [PATCH v4 16/17] vfio/pci: Remove vfio_populate_device returned value, Eric Auger, 2016/10/03