Re: [Qemu-devel] [PULL 00/28] Misc patches for 2016-09-26

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/28] Misc patches for 2016-09-26

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3d4b400 replay: allow replay stopping and restarting
7a5d340 replay: vmstate for replay module
38c889a replay: move internal data to the structure
992f16e cpus-common: lock-free fast path for cpu_exec_start/end
c9003b6 tcg: Make tb_flush() thread safe
94be4c8 cpus-common: Introduce async_safe_run_on_cpu()
ec39635 cpus-common: simplify locking for start_exclusive/end_exclusive
d0be37f cpus-common: remove redundant call to exclusive_idle()
cddcd90 cpus-common: always defer async_run_on_cpu work items
3fe593e docs: include formal model for TCG exclusive sections
0f1bd09 cpus-common: move exclusive work infrastructure from linux-user
506a000 cpus-common: fix uninitialized variable use in run_on_cpu
6758c11 cpus-common: move CPU work item management to common code
14d5392 cpus-common: move CPU list management to common code
a4a198c linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()
e098078 linux-user: Use QemuMutex and QemuCond
07ac419 cpus: Rename flush_queued_work()
31d749a cpus: Move common code out of {async_, }run_on_cpu()
d666ca5 cpus: pass CPUState to run_on_cpu helpers
88b960d build-sys: put glib_cflags in QEMU_CFLAGS
1d1948d build-sys: remove unused GLIB_CFLAGS
d2f6284 migration: sync all address spaces
1653566 compiler: Swap 'public domain' header for license
070e9b8 checkpatch: downgrade "architecture specific defines should be avoided"
36bac38 x86: ioapic: boost default version to 0x20
aa447ef intel_iommu: allow UNMAP notifiers
c0e8ae3 memory: introduce IOMMUOps.notify_flag_changed
d9543f7 memory: introduce IOMMUNotifier and its caps

=== OUTPUT BEGIN ===
Checking PATCH 1/28: memory: introduce IOMMUNotifier and its caps...
Checking PATCH 2/28: memory: introduce IOMMUOps.notify_flag_changed...
Checking PATCH 3/28: intel_iommu: allow UNMAP notifiers...
Checking PATCH 4/28: x86: ioapic: boost default version to 0x20...
Checking PATCH 5/28: checkpatch: downgrade "architecture specific defines 
should be avoided"...
ERROR: line over 90 characters
#19: FILE: scripts/checkpatch.pl:2410:
+                       WARN("architecture specific defines should be 
avoided\n" .  $herecurr);

total: 1 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/28: compiler: Swap 'public domain' header for license...
Checking PATCH 7/28: migration: sync all address spaces...
ERROR: space required before the open parenthesis '('
#58: FILE: memory.c:164:
+    } while(0)

total: 1 errors, 0 warnings, 92 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/28: build-sys: remove unused GLIB_CFLAGS...
Checking PATCH 9/28: build-sys: put glib_cflags in QEMU_CFLAGS...
Checking PATCH 10/28: cpus: pass CPUState to run_on_cpu helpers...
Checking PATCH 11/28: cpus: Move common code out of {async_, }run_on_cpu()...
Checking PATCH 12/28: cpus: Rename flush_queued_work()...
Checking PATCH 13/28: linux-user: Use QemuMutex and QemuCond...
Checking PATCH 14/28: linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick()...
Checking PATCH 15/28: cpus-common: move CPU list management to common code...
Checking PATCH 16/28: cpus-common: move CPU work item management to common 
code...
Checking PATCH 17/28: cpus-common: fix uninitialized variable use in 
run_on_cpu...
Checking PATCH 18/28: cpus-common: move exclusive work infrastructure from 
linux-user...
Checking PATCH 19/28: docs: include formal model for TCG exclusive sections...
Checking PATCH 20/28: cpus-common: always defer async_run_on_cpu work items...
Checking PATCH 21/28: cpus-common: remove redundant call to exclusive_idle()...
Checking PATCH 22/28: cpus-common: simplify locking for 
start_exclusive/end_exclusive...
Checking PATCH 23/28: cpus-common: Introduce async_safe_run_on_cpu()...
Checking PATCH 24/28: tcg: Make tb_flush() thread safe...
Checking PATCH 25/28: cpus-common: lock-free fast path for cpu_exec_start/end...
Checking PATCH 26/28: replay: move internal data to the structure...
Checking PATCH 27/28: replay: vmstate for replay module...
Checking PATCH 28/28: replay: allow replay stopping and restarting...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden