[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/28] cpus-common: always defer async_run_on_cpu wor
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 20/28] cpus-common: always defer async_run_on_cpu work items |
Date: |
Mon, 26 Sep 2016 15:40:50 +0200 |
async_run_on_cpu is only called from the I/O thread, not from CPU threads,
so it doesn't make any difference. It will make a difference however
for async_safe_run_on_cpu.
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
cpus-common.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/cpus-common.c b/cpus-common.c
index 7d935fd..115f3d4 100644
--- a/cpus-common.c
+++ b/cpus-common.c
@@ -153,11 +153,6 @@ void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func,
void *data)
{
struct qemu_work_item *wi;
- if (qemu_cpu_is_self(cpu)) {
- func(cpu, data);
- return;
- }
-
wi = g_malloc0(sizeof(struct qemu_work_item));
wi->func = func;
wi->data = data;
--
2.7.4
- [Qemu-devel] [PULL 06/28] compiler: Swap 'public domain' header for license, (continued)
- [Qemu-devel] [PULL 06/28] compiler: Swap 'public domain' header for license, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 10/28] cpus: pass CPUState to run_on_cpu helpers, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 12/28] cpus: Rename flush_queued_work(), Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 11/28] cpus: Move common code out of {async_, }run_on_cpu(), Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 13/28] linux-user: Use QemuMutex and QemuCond, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 14/28] linux-user: Add qemu_cpu_is_self() and qemu_cpu_kick(), Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 15/28] cpus-common: move CPU list management to common code, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 17/28] cpus-common: fix uninitialized variable use in run_on_cpu, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 16/28] cpus-common: move CPU work item management to common code, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 19/28] docs: include formal model for TCG exclusive sections, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 20/28] cpus-common: always defer async_run_on_cpu work items,
Paolo Bonzini <=
- [Qemu-devel] [PULL 21/28] cpus-common: remove redundant call to exclusive_idle(), Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 22/28] cpus-common: simplify locking for start_exclusive/end_exclusive, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 18/28] cpus-common: move exclusive work infrastructure from linux-user, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 23/28] cpus-common: Introduce async_safe_run_on_cpu(), Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 25/28] cpus-common: lock-free fast path for cpu_exec_start/end, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 24/28] tcg: Make tb_flush() thread safe, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 26/28] replay: move internal data to the structure, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 28/28] replay: allow replay stopping and restarting, Paolo Bonzini, 2016/09/26
- [Qemu-devel] [PULL 27/28] replay: vmstate for replay module, Paolo Bonzini, 2016/09/26
- Re: [Qemu-devel] [PULL 00/28] Misc patches for 2016-09-26, no-reply, 2016/09/26