[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar prope
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object |
Date: |
Fri, 23 Sep 2016 12:29:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.09.2016 um 14:12 hat Daniel P. Berrange geschrieben:
> On Mon, Sep 19, 2016 at 12:58:30PM +0100, Daniel P. Berrange wrote:
> > Fortunately there is no existing object that implements
> > the UserCreatable interface that relies on the list
> > handling behaviour, so it is possible to swap out the
> > OptsVisitor for a different visitor implementation, so
> > -object supports non-scalar properties, thus leaving
> > other users of OptsVisitor unaffected.
>
> Urgh, I've just discovered that this is not in fact true.
>
> The 'memory-backend' object type uses uint16List which
> has the hacky list syntax
>
> -object memory-backend-ram,\
> id=ram-node2,size=24578621440,policy=bind,\
> host-nodes=1-2,host-nodes=5,host-nodes=7,
>
> So I'll need to figure out a way to preserve this syntax...
If this turns out rather hard, would it make sense to merge just patches
1 to 5 for now to enable -blockdev, which doesn't need this syntax? Then
you can add the magic list syntax as a follow-up together with the
-object work.
Kevin
- Re: [Qemu-devel] [PATCH v13 2/6] option: make parse_option_bool/number non-static, (continued)
- [Qemu-devel] [PATCH v13 1/6] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/09/19
- [Qemu-devel] [PATCH v13 3/6] qapi: rename QmpInputVisitor to QObjectInputVisitor, Daniel P. Berrange, 2016/09/19
- [Qemu-devel] [PATCH v13 5/6] qapi: add a QObjectInputVisitor that does string conversion, Daniel P. Berrange, 2016/09/19
- [Qemu-devel] [PATCH v13 4/6] qapi: rename QmpOutputVisitor to QObjectOutputVisitor, Daniel P. Berrange, 2016/09/19
- [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/09/19
- Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/09/23
- Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object, Kevin Wolf, 2016/09/23