Re: [Qemu-devel] [PATCH v13 6/6] qom: support arbitrary non-scalar properties with -object

[Daniel P. Berrange]

On Fri, Sep 23, 2016 at 12:29:21PM +0200, Kevin Wolf wrote:
> Am 19.09.2016 um 14:12 hat Daniel P. Berrange geschrieben:
> > On Mon, Sep 19, 2016 at 12:58:30PM +0100, Daniel P. Berrange wrote:
> > > Fortunately there is no existing object that implements
> > > the UserCreatable interface that relies on the list
> > > handling behaviour, so it is possible to swap out the
> > > OptsVisitor for a different visitor implementation, so
> > > -object supports non-scalar properties, thus leaving
> > > other users of OptsVisitor unaffected.
> > 
> > Urgh, I've just discovered that this is not in fact true.
> > 
> > The 'memory-backend' object type uses uint16List which
> > has the hacky list syntax
> > 
> >   -object memory-backend-ram,\
> >           id=ram-node2,size=24578621440,policy=bind,\
> >           host-nodes=1-2,host-nodes=5,host-nodes=7,
> > 
> > So I'll need to figure out a way to preserve this syntax...
> 
> If this turns out rather hard, would it make sense to merge just patches
> 1 to 5 for now to enable -blockdev, which doesn't need this syntax? Then
> you can add the magic list syntax as a follow-up together with the
> -object work.

I've got code to deal with it and will be sending a new series, probably
on monday once i've done more testing.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|