[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] iotests: fix expected error message |
Date: |
Wed, 21 Sep 2016 17:44:45 -0400 (EDT) |
----- Original Message -----
> On 09/21/2016 03:10 PM, Marc-André Lureau wrote:
> > Missing argument returns a corresponding error message for all types
> > now.
> >
> > The "old" qmp dispatch code didn't return QERR_MISSING_PARAMETER for
> > argument structure members (it returned QERR_INVALID_PARAMETER). Only
> > for top-level argument it did return QERR_MISSING_PARAMETER. It is
> > preferable to have a consistent error for missing fields in inner
> > structs as well.
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > Reviewed-by: Alberto Garcia <address@hidden>
> > ---
> > tests/qemu-iotests/087.out | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Yes, this looks better.
>
> If the message is changed earlier in this series, then this should be
> squashed into that patch (3/4?); if the message changed as the result of
> an earlier commit, the commit message should call out the id at which
> the tree was temporarily broken.
I checked, it's the previous patch that introduce the change (I wasn't sure
given that in alternate case qapi already returned MISSING_PARAMETER), it can
be squashed with it.