[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] qapi: return a 'missing parameter' error |
Date: |
Wed, 21 Sep 2016 16:35:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/21/2016 03:10 PM, Marc-André Lureau wrote:
> The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
> parameters, but the qapi qmp_dispatch() code uses
> QERR_INVALID_PARAMETER_TYPE.
>
> Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
> appropriate.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
> qapi/qmp-input-visitor.c | 73
> +++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 56 insertions(+), 17 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature