[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object |
Date: |
Wed, 21 Sep 2016 09:15:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/21/2016 04:05 AM, Benjamin Herrenschmidt wrote:
> On Wed, 2016-09-21 at 11:51 +1000, David Gibson wrote:
>> Ok, as noted elsewhere, I think you need to disassociate the PIR value
>> from the cpu_index. It may be a little less elegant, but it'll make
>> your life much easier in the short and medium term.
>>
>> Apart from that, this looks pretty good, though I have one suggested
>> cleanup below.
>
> As long as the PIR value is what is used everywhere, ie, interrupt
> controller, XSCOM addressing of the cores, Doorbells, etc...
Yes. PowerNV needs the PIR that's all.
I need to get rid of all the different cpu identifiers which are used
under qemu. It should be possible with a "cpu hwid" -> "ipc index"
mapping table, like David proposed.
Thanks,
C.
[Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure, Cédric Le Goater, 2016/09/15