Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object

[Cédric Le Goater]

>> +static void powernv_cpu_init(PowerPCCPU *cpu, Error **errp)
>> +{
>> +    CPUPPCState *env = &cpu->env;
>> +
>> +    /* Set time-base frequency to 512 MHz */
>> +    cpu_ppc_tb_init(env, PNV_TIMEBASE_FREQ);
>> +
>> +    /* MSR[IP] doesn't exist nowadays */
>> +    env->msr_mask &= ~(1 << 6);
> 
> If MSR[IP] is gone, shouldn't that be reflected in the MSR masks
> stored for the actual vcpu models, rather than imposed from the
> machine or core code?

So, this is MSR[EP] and it is not in the msr mask of the CPUs PowerNV
runs on. We can just drop the line.

C.