|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [RFC 5/8] qom/object: update class cache atomically |
Date: | Tue, 20 Sep 2016 17:04:02 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 20/09/2016 16:59, Alex Bennée wrote: > > Looks fine to me, would be nicer to have an idea of the performance hit, > > but I suppose it is marginal. > > I was surprised that CONFIG_QOM_CAST_DEBUG is the default because it > does a bunch of stuff on every cast. The other option of course would be > to use --disable-qom-cast-debug when building for sanitizers although > maybe we should just be defaulting to off? The casts are not too expensive and usually are not in the fast paths (we use explicit C casts there) so we were leaving them enabled. They do find bugs sometimes. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |