[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes |
Date: |
Mon, 19 Sep 2016 14:06:14 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 19, 2016 at 16:51:38 +0100, Alex Bennée wrote:
> ThreadSanitizer detects a possible race between reading/writing the
> hashes. As ordering semantics are already documented for qht we just
> need to ensure a race can't tear the hash value so we can use the
> relaxed atomic_set/read functions.
This was discussed here:
https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg03658.html
To reiterate: reading torn hash values is fine, since the retry will
happen regardless (and all pointers[] remain valid through the RCU
read-critical section).
Couldn't we just tell tsan to ignore it?
Thanks,
Emilio
- Re: [Qemu-devel] [RFC 5/8] qom/object: update class cache atomically, (continued)
- [Qemu-devel] [RFC 3/8] new: blacklist.tsan, Alex Bennée, 2016/09/19
- [Qemu-devel] [RFC 4/8] seqlock: use atomic writes for the sequence, Alex Bennée, 2016/09/19
- [Qemu-devel] [RFC 8/8] .travis.yml: add gcc sanitizer build, Alex Bennée, 2016/09/19
- [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes, Alex Bennée, 2016/09/19
- Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes,
Emilio G. Cota <=