Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state

[Paolo Bonzini]

On 16/09/2016 09:56, Pavel Dovgalyuk wrote:
>>> > > +{
>>> > > +    if (replay_mode == REPLAY_MODE_RECORD) {
>>> > > +        QDict *opts = qdict_new();
>>> > > +        qdict_put(opts, "name", qstring_from_str("replay_init"));
>>> > > +        hmp_savevm(cur_mon, opts);
>>> > > +        QDECREF(opts);
>>> > > +    } else if (replay_mode == REPLAY_MODE_PLAY) {
>>> > > +        load_vmstate("replay_init");
>> > 
>> > See my other message about a suggestion to remove the hardcoded snapshot
>> > name.
>> > 
>> > Also, I think the return value of load_vmstate and hmp_savevm should be
>> > checked.
> 
> Load may be unsuccessful when the system is started with temporary overlay 
> file.
> This is ok.

This seems to be in favor of using a rrsnapshot option instead.  Using
rrsnapshot for temporary overlay would make little sense.

Paolo