Re: [Qemu-devel] [PATCH v2 07/10] replay: allow replay stopping and restarting

[Pavel Dovgalyuk]

> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 15/09/2016 11:01, Pavel Dovgalyuk wrote:
> > This patch fixes bug with stopping and restarting replay
> > through monitor.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> > diff --git a/vl.c b/vl.c
> > index f2193cb..32155f5 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -746,6 +746,7 @@ void vm_start(void)
> >      if (runstate_is_running()) {
> >          qapi_event_send_stop(&error_abort);
> >      } else {
> > +        replay_enable_events();
> 
> Can this be done with a change state notifier?

We have to be sure that events are enabled before any of the callbacks will try 
to
use events subsystem. Therefore enabling events must be the first thing to do.

Pavel Dovgalyuk