[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 2/7] option: make parse_option_bool/number no
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v8 2/7] option: make parse_option_bool/number non-static |
Date: |
Fri, 15 Jul 2016 17:13:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> writes:
> The opts-visitor.c opts_type_bool() method has code for
> parsing a string to set a bool value, as does the
> qemu-option.c parse_option_bool() method, except it
> handles fewer cases.
>
> To enable consistency across the codebase, extend
> parse_option_bool() to handle "yes", "no", "y" and
> "n", and make it non-static. Convert the opts
> visitor to call this method directly.
Baroque. But you're merely making things consistently baroque.
> Also make parse_option_number() non-static to allow
> for similar reuse later.
>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v8 0/7] Provide a QOM-based authorization API, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 3/7] qapi: add a QmpInputVisitor that does string conversion, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 2/7] option: make parse_option_bool/number non-static, Daniel P. Berrange, 2016/07/14
- Re: [Qemu-devel] [PATCH v8 2/7] option: make parse_option_bool/number non-static,
Markus Armbruster <=
- [Qemu-devel] [PATCH v8 1/7] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 4/7] qom: support arbitrary non-scalar properties with -object, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 5/7] util: add QAuthZ object as an authorization base class, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 7/7] acl: delete existing ACL implementation, Daniel P. Berrange, 2016/07/14
- [Qemu-devel] [PATCH v8 6/7] util: add QAuthZSimple object type for a simple access control list, Daniel P. Berrange, 2016/07/14