Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

[Mark Cave-Ayland]

On 23/06/16 07:14, David Gibson wrote:

> On Thu, Jun 23, 2016 at 08:08:38AM +0200, Cédric Le Goater wrote:
>> On 06/23/2016 07:50 AM, David Gibson wrote:
>>> On Wed, Jun 22, 2016 at 08:48:14AM +0200, Cédric Le Goater wrote:
>>>> On 06/22/2016 04:46 AM, David Gibson wrote:
>>>>> I'm not comfortable merging this until the openbios change is pulled
>>>>> back into the qemu tree (submodule and pre-built binary).
>>>>>
>>>>> Again - sure you don't want to apply this with rfi still enabled for
>>>>> 64-bit for now, letting the rest of this series go in as well, then
>>>>> clean up the rfi/64 behaviour later?
>>>>
>>>> Sure. I don't think it has an impact on the serie anyway so we can keep
>>>> it for later.
>>>
>>> Ok, I modified 1/10 to leave rfi in for 64-bit cpus for now, and
>>> applied the full series to ppc-for-2.7.  I've also now sent a pull
>>> request including this.
>>
>> Perfect. I was wondering if we should not just remove the instruction from 
>> the 64bit set.
> 
> We should, but I don't want to do so until OpenBIOS is updated to
> cope.

FWIW I've just sent a pull request to update the OpenBIOS images which
contains Cédric's v4 patch as reviewed by Alex:
https://www.coreboot.org/pipermail/openbios/2016-June/009461.html.


ATB,

Mark.