[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when l
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving |
Date: |
Wed, 29 Jun 2016 13:40:53 +0200 |
Hi
On Wed, Jun 29, 2016 at 12:53 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 16/06/2016 21:28, address@hidden wrote:
>> From: Marc-André Lureau <address@hidden>
>>
>> This helps to remove various chardev resources leaks when leaving qemu.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>> qemu-char.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index c926e9a..98dcd49 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -4541,6 +4541,15 @@ void qmp_chardev_remove(const char *id, Error **errp)
>> qemu_chr_delete(chr);
>> }
>>
>> +static void qemu_chr_cleanup(void)
>> +{
>> + CharDriverState *chr;
>> +
>> + QTAILQ_FOREACH(chr, &chardevs, next) {
>> + qemu_chr_delete(chr);
>> + }
>> +}
>
> FYI, this patch is necessary on top:
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 016badb..bc04ced 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -4551,9 +4551,9 @@
>
> static void qemu_chr_cleanup(void)
> {
> - CharDriverState *chr;
> + CharDriverState *chr, *tmp;
>
> - QTAILQ_FOREACH(chr, &chardevs, next) {
> + QTAILQ_FOREACH_SAFE(chr, &chardevs, next, tmp) {
> qemu_chr_delete(chr);
> }
> }
>
ack, I guess you'll have it in your pull request? squash or seperate, anyhow.
thanks
--
Marc-André Lureau
- [Qemu-devel] [PATCH v2 0/3] chardev cleanups, marcandre . lureau, 2016/06/16
- [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving, marcandre . lureau, 2016/06/16
- [Qemu-devel] [PATCH v2 2/3] socket: add listen feature, marcandre . lureau, 2016/06/16
- [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, marcandre . lureau, 2016/06/16
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Marc-André Lureau, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Marc-André Lureau, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Daniel P. Berrange, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove, Michael S. Tsirkin, 2016/06/24