[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] replay: allow replay stopping and restartin
From: |
Pavel Dovgalyuk |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] replay: allow replay stopping and restarting |
Date: |
Wed, 29 Jun 2016 14:40:05 +0300 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 20/06/2016 08:26, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:address@hidden
> >>> From: "Pavel Dovgalyuk" <address@hidden>
> >>> This patch fixes bug with stopping and restarting replay
> >>> through monitor.
> >>>
> >>> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> >>> ---
> >
> >> I think that you want to call
> >> replay_disable_events...
> >>
> >>> bdrv_drain_all();
> >>
> >> ... after this bdrv_drain_all.
> >
> > Why? We disable replay events to avoid adding new block requests
> > to the queue. How this is related to drain all?
>
> drain all completes the guest's pending requests. If you disable events
> before drain all, doesn't that cause a mismatch between record and replay?
Looks reasonable, thanks. I'll update the patch.
What about replay patch for networking?
Pavel Dovgalyuk
[Qemu-devel] [PATCH 1/3] target-ppc: exceptions handling in icount mode, Pavel Dovgalyuk, 2016/06/08
[Qemu-devel] [PATCH 3/3] record/replay: add network support, Pavel Dovgalyuk, 2016/06/08