[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marsha
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions |
Date: |
Thu, 23 Jun 2016 22:23:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/22/2016 06:08 PM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Once the middle mode is removed, the generated marshal functions will no
> longer be exported.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> monitor.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index fc691b9..585bc1f 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3609,21 +3609,21 @@ static int monitor_can_read(void *opaque)
> return (mon->suspend_cnt == 0) ? 1 : 0;
> }
>
> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd,
> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd,
Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make
sense, but gchar is not one of them)
> @@ -3914,7 +3914,7 @@ static void handle_qmp_command(JSONMessageParser
> *parser, GQueue *tokens)
> "The command %s has not been found", cmd_name);
> goto err_out;
> }
> - if (invalid_qmp_mode(mon, cmd, &local_err)) {
> + if (invalid_qmp_mode(mon, cmd_name, &local_err)) {
> goto err_out;
Particularly since cmd_name is const char * in the caller.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature