[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated comm
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands |
Date: |
Thu, 23 Jun 2016 05:02:30 -0400 (EDT) |
Hi
----- Original Message -----
>
>
> On 23/06/2016 02:08, address@hidden wrote:
> >
> > Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
> > from generated qapi commands registry.
> >
> > Note: this commit requires a 'make clean' prior to make, since the
> > generated files do not depend on Makefile (due to a cyclic rule
> > introduced in 4115852bb0).
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
>
> What is the cyclic dependency?
We have in Makefile.target:
Makefile: $(GENERATED_HEADERS)
But we should also or rather have:
$(GENERATED_HEADERS) $(GENERATED_SOURCES): Makefile:
That would be cyclic.
I understand the first rule was added to simplify the dependencies and make
sure the generated files are done prior to any building. But it sounds like
it's not a conventional way to write your rules and prevent proper dependencies.
Do you know another trick we could use for the generated files?
regards
- [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions, (continued)
- [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add', marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities', marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands, marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds, marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new, marcandre . lureau, 2016/06/22
[Qemu-devel] [PATCH 08/12] build-sys: remove qmp-commands-old.h, marcandre . lureau, 2016/06/22
[Qemu-devel] [PATCH 09/12] qapi: remove the "middle" mode, marcandre . lureau, 2016/06/22
[Qemu-devel] [PATCH 10/12] monitor: use qmp_dispatch(), marcandre . lureau, 2016/06/22