[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io |
|
Date: |
Wed, 8 Jun 2016 13:23:57 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
> From: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> Acquire aio context before run command, this is mandatory for unit tests.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Paolo Bonzini <address@hidden>
Looks right to me, but why "mandatory for unit tests"? Does this fix an
observable bug in unit tests? If so, we should be more specific in the
commit message.
But in fact, I would only expect it to make a difference for dataplane
and I don't think we have test cases that use both the 'qemu-io' HMP
command and dataplane.
Kevin