Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

[Denis V. Lunev]

On 06/14/2016 11:44 AM, Kevin Wolf wrote:
> Am 14.06.2016 um 10:34 hat Denis V. Lunev geschrieben:
> > On 06/08/2016 02:23 PM, Kevin Wolf wrote:
> > > Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben:
> > > > From: Vladimir Sementsov-Ogievskiy <address@hidden>
> > > >
> > > > Acquire aio context before run command, this is mandatory for unit tests.
> > > >
> > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > > > Signed-off-by: Denis V. Lunev <address@hidden>
> > > > CC: Kevin Wolf <address@hidden>
> > > > CC: Paolo Bonzini <address@hidden>
> > > Looks right to me, but why "mandatory for unit tests"? Does this fix an
> > > observable bug in unit tests? If so, we should be more specific in the
> > > commit message.
> > >
> > > But in fact, I would only expect it to make a difference for dataplane
> > > and I don't think we have test cases that use both the 'qemu-io' HMP
> > > command and dataplane.
> > >
> > > Kevin
> > the problem is that it is usually difficult to understand that
> > the problem is in locking and find where the locking is missed.
> > Here we do have a place, which is used by unit testing, with
> > a locking missed.
> >
> > May be now tests are not failing, but IMHO these tests MUST
> > be fixed to accommodate future changes and thus this patch
> > is mandatory for them.
> I was never objecting to the patch, but just curious about the details
> of a possible failure you were seeing because I didn't see how to hit
> it in practice without dataplane.
>
> Sorry for forgetting about the patch, I've applied it now.
>
> Kevin
thank you ;)

Den