[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP |
Date: |
Mon, 6 Jun 2016 15:17:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 05/06/2016 09:43, Michael Tokarev wrote:
> From: Laurent Vivier <address@hidden>
>
> Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d).
>
> This patch is the result of coccinelle script
> scripts/coccinelle/round.cocci
>
> CC: Cornelia Huck <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
> pc-bios/s390-ccw/bootmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
> index 611102e..ecdc52d 100644
> --- a/pc-bios/s390-ccw/bootmap.c
> +++ b/pc-bios/s390-ccw/bootmap.c
> @@ -599,7 +599,7 @@ static void load_iso_bc_entry(IsoBcSection *load)
>
> if (real_size) {
> /* Round up blocks to load */
> - blks_to_load = (real_size + ISO_SECTOR_SIZE - 1) / ISO_SECTOR_SIZE;
> + blks_to_load = DIV_ROUND_UP(real_size, ISO_SECTOR_SIZE);
> sclp_print("ISO boot image size verified\n");
> } else {
> sclp_print("ISO boot image size could not be verified\n");
>
I think this one must be dropped from the pull request as s390-ccw files
have no access to the definition of DIV_ROUND_UP.
I missed that because it is not built by default and can only be built
on a s390 system (or with some tricks with a cross-compiler).
Thanks,
Laurent
- [Qemu-devel] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one., (continued)
- [Qemu-devel] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one., Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 11/52] remove useless muldiv64(), Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 08/52] gdbstub: set listen backlog to 1, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 19/52] monitor: Typo fix, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 14/52] Fix linking relocatable objects on Sparc, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 25/52] Fix configure test for PBKDF2 in nettle, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 20/52] qdev: Clean up around properties, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 31/52] all: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 07/52] po/Makefile: call rm -f directly, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- Re: [Qemu-devel] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP,
Laurent Vivier <=
- [Qemu-devel] [PULL 42/52] crypto: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 36/52] thunk: Rename args and fields in host-target bitmask conversion code, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 24/52] docs: Fix a couple of typos in throttle.txt, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 29/52] tests: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 52/52] hbitmap: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 13/52] ppc: Remove a potential overflow in muldiv64(), Michael Tokarev, 2016/06/05