[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/52] The only 64bit parameter of muldiv64() is the
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one. |
Date: |
Sun, 5 Jun 2016 10:42:47 +0300 |
From: Laurent Vivier <address@hidden>
muldiv64() is "uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)"
Some time it is used as muldiv64(uint32_t a, uint64_t b, uint32_t c)"
This patch is the result of coccinelle script
scripts/coccinelle/swap_muldiv64.cocci to reorder arguments.
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/timer/omap_gptimer.c | 4 ++--
hw/usb/hcd-ohci.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/timer/omap_gptimer.c b/hw/timer/omap_gptimer.c
index 3a43863..5e3e8a6 100644
--- a/hw/timer/omap_gptimer.c
+++ b/hw/timer/omap_gptimer.c
@@ -133,8 +133,8 @@ static inline void omap_gp_timer_update(struct
omap_gp_timer_s *timer)
timer_mod(timer->timer, timer->time + expires);
if (timer->ce && timer->match_val >= timer->val) {
- matches = muldiv64(timer->match_val - timer->val,
- timer->ticks_per_sec, timer->rate);
+ matches = muldiv64(timer->ticks_per_sec,
+ timer->match_val - timer->val, timer->rate);
timer_mod(timer->match, timer->time + matches);
} else
timer_del(timer->match);
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 16d9ff7..25cc53f 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1474,7 +1474,7 @@ static uint32_t ohci_get_frame_remaining(OHCIState *ohci)
if (tks >= usb_frame_time)
return (ohci->frt << 31);
- tks = muldiv64(1, tks, usb_bit_time);
+ tks = muldiv64(tks, 1, usb_bit_time);
fr = (uint16_t)(ohci->fi - tks);
return (ohci->frt << 31) | fr;
--
2.1.4
- [Qemu-devel] [PULL 00/52] Trivial patches for 2016-06-05, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 09/52] scripts: add muldiv64() checking coccinelle scripts, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 06/52] target-moxie: Remove unused struct elements, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one.,
Michael Tokarev <=
- [Qemu-devel] [PULL 11/52] remove useless muldiv64(), Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 08/52] gdbstub: set listen backlog to 1, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 19/52] monitor: Typo fix, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 14/52] Fix linking relocatable objects on Sparc, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 25/52] Fix configure test for PBKDF2 in nettle, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 20/52] qdev: Clean up around properties, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 31/52] all: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 07/52] po/Makefile: call rm -f directly, Michael Tokarev, 2016/06/05
- [Qemu-devel] [PULL 50/52] pc-bios/s390-ccw: Use DIV_ROUND_UP, Michael Tokarev, 2016/06/05