[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V4 25/31] i.MX: Fix FEC code for MDIO address selecti
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V4 25/31] i.MX: Fix FEC code for MDIO address selection |
Date: |
Thu, 2 Jun 2016 14:48:16 +0800 |
From: Jean-Christophe Dubois <address@hidden>
According to the FEC chapter of i.MX25 reference manual
When writing to MMFR register, the MDIO device and adress are selected by
bit 27 to 23 and bit 22 to 18 respectively. This is a total of 10 bits
that need to be used by the Phy chip/address decoding function.
This patch fixes the number of bits used from 9 to 10.
Signed-off-by: Jean-Christophe Dubois <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/imx_fec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index fce3661..bf68ce6 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -460,9 +460,9 @@ static void imx_fec_write(void *opaque, hwaddr addr,
/* store the value */
s->mmfr = value;
if (extract32(value, 29, 1)) {
- s->mmfr = do_phy_read(s, extract32(value, 18, 9));
+ s->mmfr = do_phy_read(s, extract32(value, 18, 10));
} else {
- do_phy_write(s, extract32(value, 18, 9), extract32(value, 0, 16));
+ do_phy_write(s, extract32(value, 18, 10), extract32(value, 0, 16));
}
/* raise the interrupt as the PHY operation is done */
s->eir |= FEC_INT_MII;
--
2.7.4
- [Qemu-devel] [PULL V4 14/31] net_pkt: Name vmxnet3 packet abstractions more generic, (continued)
- [Qemu-devel] [PULL V4 14/31] net_pkt: Name vmxnet3 packet abstractions more generic, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 17/31] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 16/31] net_pkt: Extend packet abstraction as required by e1000e functionality, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 18/31] e1000_regs: Add definitions for Intel 82574-specific bits, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 19/31] e1000: Move out code that will be reused in e1000e, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 22/31] net: improve UDP/TCP checksum computation., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 21/31] e1000e: Introduce qtest for e1000e device, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 24/31] i.MX: Fix FEC code for MDIO operation selection, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 23/31] net: handle optional VLAN header in checksum computation., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 26/31] i.MX: Fix FEC code for ECR register reset value., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 25/31] i.MX: Fix FEC code for MDIO address selection,
Jason Wang <=
- [Qemu-devel] [PULL V4 27/31] i.MX: reset TX/RX descriptors when FEC is disabled., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 28/31] i.MX: Rename i.MX FEC defines to ENET_XXX, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 20/31] net: Introduce e1000e device emulation, Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 29/31] i.MX: move FEC device to a register array structure., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 31/31] Add ENET device to i.MX6 SOC., Jason Wang, 2016/06/02
- [Qemu-devel] [PULL V4 30/31] Add ENET/Gbps Ethernet support to FEC device, Jason Wang, 2016/06/02
- Re: [Qemu-devel] [PULL V4 00/31] Net patches, Peter Maydell, 2016/06/02