|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [RFC v2 PATCH 02/13] tcg/i386: Add support for fence |
| Date: | Tue, 31 May 2016 13:27:16 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 05/31/2016 11:39 AM, Pranith Kumar wrote:
+ case INDEX_op_mb: + tcg_out_mb(s);
You need to look at the barrier type and DTRT. In particular, the Linux smp_rmb and smp_wmb types need not emit any code.
+ { INDEX_op_mb, { "r" } },
You certainly do *not* need the constant argument loaded into a register. This should remain { }.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |