[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 1/6] qemu-io: Add missing option documentatio

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 1/6] qemu-io: Add missing option documentation
Date: Mon, 9 May 2016 19:43:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 08.05.2016 05:16, Eric Blake wrote:
> The Usage: summary is missing several options, but rather than
> having to maintain it, it's simpler to just state [OPTIONS],
> since the options are spelled out below.
> Commit 499afa2 added --image-opts, but forgot to document it in
> --help.  Likewise for commit 9e8f183 and -d/--discard.
> Commit e3aff4f6 put "-o/--offset" in the long opts, but it has
> never been honored.
> Add a note that '-n' is short for '-t none'.
> Commit 9a2d77ad killed the -C option, but forgot to undocument
> it for the 'open' subcommand.
> Finally, commit 10d9d75 removed -g/--growable, but forgot to
> cull it from the valid short options.
> Signed-off-by: Eric Blake <address@hidden>
> ---
> v5: more improvements
> ---
>  qemu-io.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]