Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default

[Max Reitz]

On 08.05.2016 05:16, Eric Blake wrote:
> There's no reason to require the user to specify a flag just so
> they can pass in unaligned numbers.  Keep 'read -p' and 'write -p'
> as no-ops so that I don't have to hunt down and update all users
> of qemu-io, but otherwise make their behavior default as 'read' and
> 'write'.  Also fix 'write -z', 'readv', 'writev', 'writev',
> 'aio_read', 'aio_write', and 'aio_write -z'.  For now, 'read -b',
> 'write -b', and 'write -c' still require alignment (and 'multiwrite',
> but that's slated to die soon).
> 
> qemu-iotest 23 is updated to match, as the only test that was
> previously explicitly expecting an error on an unaligned request.
> 
> Signed-off-by: Eric Blake <address@hidden>
> 
> ---
> v5: use bool operator, drop spurious spaces in .args

If I had realized how many of these spaces there are, I probably
wouldn't have asked for it. :-)

> ---
>  qemu-io-cmds.c             |   73 +-
>  tests/qemu-iotests/023.out | 2160 
> +++++++++++++++++++++++++++++---------------
>  2 files changed, 1457 insertions(+), 776 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature