[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/
Date: Tue, 15 Mar 2016 16:27:27 +0200

On Tue, Mar 15, 2016 at 03:25:01PM +0100, Gerd Hoffmann wrote:
> On Di, 2016-03-15 at 15:14 +0100, Paolo Bonzini wrote:
> > 
> > On 15/03/2016 14:55, Michael S. Tsirkin wrote:
> > > Allowing arbitary file names on command line is setting us up for
> > > failure: future guests will look for a specific QEMU-specified name and
> > > will get confused finding a user file there.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > 
> > Too bad for the user.
> > 
> > I think we have already gone through this discussion.
> Indeed, we discussed that before.
> If users ignore the warning it's their fault.

Everyone ignores warnings. So it's user's fault for using QEMU.

> Being able to set entries outside opt/ can be useful for debugging and
> development purposes, this is the reason it is a warning only and not a
> hard error.
> cheers,
>   Gerd

Add an unsupported flag there then. We have the rule that
flags starting with x- are for internal purposes, use that.
"x-unsupported-fw-cfg"? Don't trap users into
using a feature and then blaming them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]