[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/
Date: Tue, 15 Mar 2016 15:54:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 15/03/2016 15:25, Michael S. Tsirkin wrote:
> Do you look at all warnings all your software prints?

Yes.  I also try to understand them, and if they seem useless I propose
a patch upstream.

> What if user uses some tool to build the command line?
> consider mem-path - for years we printed a warning if
> it's not on hugetlbfs. It worked and users just ignored it.

That was a bad warning though.  There was no reason to warn.

It was also the smallest problem with the original hugetlbfs patches.

> So now Corey basically is prevented from sorting sanely
> because command line might not start with opt/

Can you explain?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]